Skip to content

Make model_averaging.ipynb runnable, fix formula typo #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

MarcoGorelli
Copy link
Contributor

Couple of things:

  • original notebook accessed a local csv file, so I've replaced that with one from pymc/resources
  • pretty sure the formula reported had a typo, as we're maximising the weights rather than the number of points (the original paper at least has w instead of N)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -3,7 +3,22 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I changed here was to maximise over w rather than over N


Reply via ReviewNB

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #4271 (f6db586) into master (edbafaa) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
+ Coverage   87.44%   87.47%   +0.02%     
==========================================
  Files          88       88              
  Lines       14342    14342              
==========================================
+ Hits        12542    12545       +3     
+ Misses       1800     1797       -3     
Impacted Files Coverage Δ
pymc3/parallel_sampling.py 86.79% <0.00%> (+0.94%) ⬆️

@MarcoGorelli MarcoGorelli changed the title Make model_averaging.ipynb runnable, fix formua typo Make model_averaging.ipynb runnable, fix formula typo Nov 29, 2020
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelosthege michaelosthege merged commit ced05db into pymc-devs:master Dec 3, 2020
@MarcoGorelli MarcoGorelli deleted the fix-model-averaging branch December 4, 2020 12:47
@MarcoGorelli
Copy link
Contributor Author

Thanks! Time to cross off exercise 7, chapter 5 from Osvaldo's book:

Read and run the model averaging example from PyMC3's documentation at
https:/​/docs.​pymc.​io/notebooks/​model_​averaging.​html .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants