Skip to content

Fix ODE NB. #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2020
Merged

Fix ODE NB. #3887

merged 2 commits into from
May 13, 2020

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented Apr 20, 2020

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@twiecki twiecki marked this pull request as draft April 20, 2020 13:46
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #3887 into master will decrease coverage by 1.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
- Coverage   90.74%   89.18%   -1.56%     
==========================================
  Files         135      152      +17     
  Lines       21130    23483    +2353     
==========================================
+ Hits        19174    20944    +1770     
- Misses       1956     2539     +583     
Impacted Files Coverage Δ
pymc3/step_methods/hmc/base_hmc.py 95.32% <0.00%> (-0.94%) ⬇️
pymc3/distributions/discrete.py 74.04% <0.00%> (-0.48%) ⬇️
pymc3/gp/cov.py 98.03% <0.00%> (-0.08%) ⬇️
pymc3/backends/tracetab.py 100.00% <0.00%> (ø)
pymc3/distributions/__init__.py 100.00% <0.00%> (ø)
pymc3/examples/samplers_mvnormal.py 0.00% <0.00%> (ø)
pymc3/examples/arbitrary_stochastic.py 0.00% <0.00%> (ø)
pymc3/examples/garch_example.py 0.00% <0.00%> (ø)
pymc3/examples/rankdata_ordered.py 0.00% <0.00%> (ø)
pymc3/examples/disaster_model.py 0.00% <0.00%> (ø)
... and 26 more

@twiecki twiecki marked this pull request as ready for review May 12, 2020 12:59
@twiecki
Copy link
Member Author

twiecki commented May 12, 2020

The ODE NB was using old API, I fixed this alongside some other smaller issues.

Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@fonnesbeck fonnesbeck merged commit e47b98a into master May 13, 2020
@michaelosthege michaelosthege deleted the fix_ode_nb branch March 10, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants