Skip to content

CheckParameterValues not replaced in inner graphs #6697

Open
@ricardoV94

Description

@ricardoV94

We include these rewrites when compiling logp graphs, but this won't replace inner logp graphs (e.g, inside Scan or not-inlined OpFromGraph)

pymc/pymc/pytensorf.py

Lines 1142 to 1144 in 371472d

check_parameter_opt = (
"local_check_parameter_to_ninf_switch" if check_bounds else "local_remove_check_parameter"
)

The example in #6696 suffers from this. Sampling is quite faster when the rewrite is manually added

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions