Skip to content

minor update: pathfinder notebook #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

aphc14
Copy link
Contributor

@aphc14 aphc14 commented Feb 13, 2025

Description

Updates pathfinder notebook to use the Pathfinder implementation since pymc-extras>=0.2.2 to better compare Pathfinder's performance compared to NUTS sampling for the eight schools dataset.

Note: This is just an interim update to the notebook while a more detailed notebook, tutorial and case-study of Pathfinder is underway!

resolves #572

Checklist


📚 Documentation preview 📚: https://pymc-examples--774.org.readthedocs.build/en/774/

…tras>=0.2.2

- Add NUTS sampling results for comparison
- Set  for better comparison of Pathfinder and NUTS
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fonnesbeck fonnesbeck self-assigned this Feb 18, 2025
Copy link
Member

@fonnesbeck fonnesbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fonnesbeck fonnesbeck merged commit c8bbca4 into pymc-devs:main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major issues in Pathfinder example
2 participants