corrected formula (added missing log) #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks! |
twiecki
added a commit
that referenced
this pull request
Jan 17, 2023
* added model_builder * added explanation * added tests * formatting * change in save and load method * updated save and load methods * fixed more errors * fixed path variable in save and load * Documentation * Documentation * fixed formatting and tests * fixed docstring * fixed minor issues * fixed minor issues * Update pymc_experimental/model_builder.py Co-authored-by: Michael Osthege <michael.osthege@outlook.com> * Update pymc_experimental/model_builder.py Co-authored-by: Michael Osthege <michael.osthege@outlook.com> * fixed spelling errors * Update pymc_experimental/model_builder.py Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com> * Update pymc_experimental/model_builder.py * Update pymc_experimental/model_builder.py * added build method again * Update pymc_experimental/tests/test_model_builder.py * removed unecessary imports * changed arviz to az * fixed codes to pass build tests * linespace -> linspace * updated test_model_builder.py * updated model_builder.py * fixed overloading of test_fit() * fixed indentation in docstring * added some better examples * fixed test.yml * indetation * Apply suggestions from code review * Update pymc_experimental/model_builder.py * Update pymc_experimental/model_builder.py Co-authored-by: Michael Osthege <michael.osthege@outlook.com> Co-authored-by: Thomas Wiecki <thomas.wiecki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to issue #63, fixes a typo, is not part of the notebook update project