-
-
Notifications
You must be signed in to change notification settings - Fork 271
External nuts sampler #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Looks like this model is pretty much a benchmark of the matrix multiply speed in the different backends. I also get warnings from the numba backend:
Maybe the ordered transform introduces some non-contigous arrays? |
@twiecki Could you maybe check what you get for sampling time alone and compile time alone for numba? Ie
(for me compilation is ~11s and sampling ~4s) We should also use a fixed seed in the notebook, otherwise the data will be different each time we execute it. For me neither of the samplers ends up with a converged posterior, which makes comparing the times pretty pointless, but that might just be because of the seed I used... |
I added a seed. compilation time is rather low for this model. Wall time: 33.4 s for compilation + sampling vs 47s for just sampling. |
Cause of Numba slowness (as "debugged" with @aseyboldt just now): OpenBLAS. Installing Accelerate via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I have commented on the myst file, but make the changes to the ipynb file
@OriolAbril I have implemented the requested changes. |
Update previous JAX sampling NB
The previous NB was very outdated, I changed the example to be PPCA and update to use
nuts_sampler
kwarg.@aseyboldt nutpie is kinda slow on this example, not sure why.