Skip to content

Out-of-sample predictions for BART intro notebook #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Jan 25, 2023

Out-of-sample predictions for BART intro notebook

Closes pymc-devs/pymc-bart#48

  • Add a section regarding out-of-sample predictions for the existing bikes example.
  • Add a comment regarding extrapolating with BART models.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz changed the title add out-os-sample section add out-of-sample section Jan 25, 2023
@juanitorduz juanitorduz changed the title add out-of-sample section Out-of-sample predictions for BART intro notebook Jan 25, 2023
@aloctavodia
Copy link
Member

Thanks!

What about adding a first OOS example where you treat the problem as a regression and then a second one (the one you already wrote) showing that BART is not good at extrapolation?

@juanitorduz
Copy link
Collaborator Author

Thanks!

What about adding a first OOS example where you treat the problem as a regression and then a second one (the one you already wrote) showing that BART is not good at extrapolation?

Sure! I will add the OOS part to the first example as well. Should I keep the bikes example as it is?

@aloctavodia
Copy link
Member

I would not change what you already added. What I would add is an example of out-of-sample predictions using the bike dataset, with the only difference being that we treat it as a regression problem, not a time-series problem.

We can keep the coal mining example unmodified.

@juanitorduz
Copy link
Collaborator Author

I added a regression-like example in ae24deb

Copy link
Member

@aloctavodia aloctavodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks!

@OriolAbril
Copy link
Member

@juanitorduz just for completeness, you have added significant piece of new code, so you should add yourself to both the authors section at the bottom (like you did) and at the :author: metadata at the beginning. Feel free to update whenever you work on another notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example using shared variables
3 participants