Skip to content

GLM-robust update #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

GLM-robust update #451

wants to merge 20 commits into from

Conversation

kuvychko
Copy link
Contributor

Tracker Issue #88

Summary of changes:

  • Updated links to Thomas's blog posts (old links were obsolete/broken)
  • Changed code that uses pm.plot_posterior_predictive_glm since this method is no longer in pymc
    • I experimented with arviz.plot_lm but couldn't get a comparable plot
    • Instead, I explicitly computed and plotted a subset of regression lines using coefficients from posterior. Personally I think it is helpful to have an example of a more explicit calculation/visualization like that.
  • Updated link to Kruschke's "puppy" book since the link to U of Indiana no longer works. Instead I put a link to Elsevier's book page.
  • Updated rv.logp(x) method to pm.logp(rv, x) since the original method was removed
  • Added Authors section at the end of the notebook

kuvychko and others added 20 commits July 22, 2022 11:27
@kuvychko
fixing random seed issue in pm.Model definition
1650a34
@kuvychko
re-run and saved with jupytext installed
7ace1d1
@kuvychko
re-run and updated spline.myst.md
8581474
@kuvychko
pre-commit passing
915c849
@kuvychko
Merge pull request #1 from pymc-devs/main
4699e1d 
update fork
@kuvychko
re-wrote examples/howto_debugging.ipynb
b31c035
@kuvychko
re-wrote examples/howto_debugging.ipynb
d09ace6
@kuvychko
re-wrote examples/howto_debugging.ipynb
61b9a1e
@kuvychko
Merge pull request #2 from pymc-devs/main
684e985 
Rebasing
@azihna @kuvychko
Add header and footers for hierarchical partial pooling (pymc-devs#393)
074adf6 
* Fix start and end of the files

* Fix start and end for ipynb

* Fix start and end for ipynb

* Fix start and end for ipynb

* Fix notebook name and watermark

* Pass pre-commit

* Add authorship

* Pre-commit checks

Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com>
@ckrapu @kuvychko
Update stochastic volatility notebook for best practices (pymc-devs#378)
d4ad7bf 
* Bring stochastic volatility notebook in line with style guide

Fixing dashes in reference entry

Removing extra lines from reference bib file

* Adding original author information to stochastic volatility notebook

* Adding updated myst file

* Fixing misspecified tags and updating author list

* Update stochastic_volatility.myst.md
@symeneses @AnaRita93 @kuvychko
Upgrade notebook Gaussian Process to V4 (pymc-devs#404)
a9c674b 
* ⬆️ upgrade nb to V4

Co-authored-by: Ana Rita Santos <ar.oliveirasantos@gmail.com>

* 👌 updates due to review comments

* 👌 sampling with multivariate_normal from xarray_einstats dev

* 📌 set ablog version

* 🍻 🐛 fix the pinning

* 📌 pin sphinx and sphinx gallery

* 📝 add watermark header

Co-authored-by: Ana Rita Santos <ar.oliveirasantos@gmail.com>
@reshamas @kuvychko
Notebook divergence, update header and footer (pymc-devs#402)
9f290f9 
* notebook: divergences; update notebook formatting

* notebook divergence: updates,figure metadata

* Divergence nb: run notebook

* make code across one line

* make code one line to fix myst errors from precommit

* rm space around = sign

* nb divergence: fix myst error with spacing

* make Authorship section consistent betw notebook and myst

* remove myst file

* divergence notebook, after running pre-commit

* run myst for divergence nb

* added RS authorship to end

* rerun myst on divergence nb

* divergence nb: rerun myst
@kuvychko
Merge pull request #4 from pymc-devs/main
df7958f 
Re-wrote "How to debug a model" (pymc-devs#406)
@kuvychko
Merge remote-tracking branch 'origin/main'
7e09f38
@kuvychko
Merge pull request #5 from pymc-devs/main
1719fc9 
Reinforcement Learning Notebook (pymc-devs#410)
@kuvychko
Merge pull request #6 from pymc-devs/main
4bbafba 
Catching up with main
@kuvychko
Merge remote-tracking branch 'origin/main'
f92adb8
@kuvychko
updated GLM-robust.ipynb
4f02c49
@kuvychko
updated GLM-robust.ipynb
9105a94
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kuvychko
Copy link
Contributor Author

kuvychko commented Nov 5, 2022

@OriolAbril @reshamas - it looks like this change hasn't been reviewed yet (I filed this PR 16 days ago). clearly no rush with this, but I want to make sure it doesn't fall through the cracks. Thanks!

@OriolAbril OriolAbril mentioned this pull request Nov 5, 2022
Closed
@OriolAbril
Copy link
Member

We currently have 3 PRs open for this same notebook: #356, #445, #451. And I am not sure how to go about this, git conflicts on notebooks are a nightmare. I might try to merge the myst and then update the notebook from it which might happen in a 4th PR overriding the current 3. I will take a look and work on this next week. Thank you all for the PRs, I'll make sure at the very least you are listed as co-author in the merged PR.

@OriolAbril OriolAbril mentioned this pull request Nov 5, 2022
Closed
3 tasks
@kuvychko
Copy link
Contributor Author

kuvychko commented Nov 6, 2022

@OriolAbril - ouch, I see! That's unfortunate, my apologies that it took me so long to finish with it!

@reshamas
Copy link
Member

reshamas commented Dec 6, 2022

@kuvychko
Can you send me the email address you use for GitHub, so @OriolAbril can add you as a co-author on the GLM-robust notebook?

@OriolAbril OriolAbril mentioned this pull request Dec 6, 2022
Merged
3 tasks
@OriolAbril
Copy link
Member

Superseded by #472

@OriolAbril OriolAbril closed this Dec 6, 2022
@kuvychko
Copy link
Contributor Author

kuvychko commented Dec 6, 2022

@reshamas - sure thing, igor.kuvychko@gmail.com

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kuvychko @OriolAbril @reshamas @azihna @ckrapu @symeneses