Linear nodes attempt 🙈 #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this! I am not able to provide feedback right now. But I will do it ASAP. |
|
No rush! It will take me some time to go through the code and make sense of it which is the best approach in contrast to the brute force way hehe. |
Closed
|
I will close this one to work on a new one as I have gained some useful learnings in #76 (Also I do not feel like resolving conflicts 😅 ) |
|
Perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #51
I really want to have the linear nodes hehe. So this is a draft PR to try to port the changes added in pymc-devs/pymc#5044 . The code-base has changed a bit so I need to catch up in understanding the code more. If someone could give me some guidance it would be much appreciated. I feel this is a relatively "low-hanging-fruit" but as always, the devil is in the details.