Skip to content

Support ForeignKey relations with to keyword. Fixes #223 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2019
Merged

Support ForeignKey relations with to keyword. Fixes #223 #224

merged 1 commit into from
Apr 15, 2019
+24 −4

Conversation

fadedDexofan
Copy link
Contributor

Added support for to keyword FK relations. See #223

@coveralls
Copy link

Pull Request Test Coverage Report for Build 640

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 640

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 640

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 640

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 640

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 645

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 86.95%
Totals Coverage Status
Change from base Build 605: 0.06%
Covered Lines: 613
Relevant Lines: 705
💛 - Coveralls

atodorov
atodorov suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thank you for your time.

Minor change requested and also add Fixes #223 to your commit log, so that GitHub closes the issue automatically when we merge. I will push a new version shortly after this is merged (can even be today).

@fadedDexofan fadedDexofan changed the title Support ForeignKey relations with to keyword Fixes #223 Support ForeignKey relations with to keyword Apr 12, 2019
@fadedDexofan fadedDexofan changed the title Fixes #223 Support ForeignKey relations with to keyword Support ForeignKey relations with to keyword. Fixes #223 Apr 12, 2019
@atodorov atodorov merged commit 92f3975 into pylint-dev:master Apr 15, 2019
@fadedDexofan fadedDexofan deleted the keyword-relations branch April 16, 2019 03:45
@decibyte decibyte mentioned this pull request Apr 25, 2019
Closed
atodorov added a commit that referenced this pull request Apr 26, 2019
@atodorov
Add new test for GenericForeignKey. Refs #230, #224
9d55e9a
atodorov added a commit that referenced this pull request Apr 26, 2019
@atodorov
Add new test for GenericForeignKey. Refs #230, #224
8a034c6
atodorov added a commit that referenced this pull request Apr 26, 2019
@atodorov
Add new test for GenericForeignKey. Refs #230, #224
27b8c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atodorov atodorov atodorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fadedDexofan @coveralls @atodorov