Compatibility with pylint 3.0

[matejsp]

When trying to test upgrade pylint to 3.0 that will be released in couple of days.

pip install pylint==3.0.0b0
Requirement already satisfied: platformdirs>=2.2.0 in ./.venv/lib/python3.11/site-packages (from pylint==3.0.0b0) (3.10.0)
Requirement already satisfied: isort<6,>=4.2.5 in ./.venv/lib/python3.11/site-packages (from pylint==3.0.0b0) (5.12.0)
Requirement already satisfied: mccabe<0.8,>=0.6 in ./.venv/lib/python3.11/site-packages (from pylint==3.0.0b0) (0.7.0)
Requirement already satisfied: tomlkit>=0.10.1 in ./.venv/lib/python3.11/site-packages (from pylint==3.0.0b0) (0.12.1)
Requirement already satisfied: dill>=0.3.6 in ./.venv/lib/python3.11/site-packages (from pylint==3.0.0b0) (0.3.6)
Installing collected packages: astroid, pylint
  Attempting uninstall: astroid
    Found existing installation: astroid 2.15.6
    Uninstalling astroid-2.15.6:
      Successfully uninstalled astroid-2.15.6
  Attempting uninstall: pylint
    Found existing installation: pylint 2.17.5
    Uninstalling pylint-2.17.5:
      Successfully uninstalled pylint-2.17.5
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pylint-django 2.5.3 requires pylint<3,>=2.0, but you have pylint 3.0.0b0 which is incompatible.
Successfully installed astroid-3.0.0 pylint-3.0.0b0

(.venv) ➜  xxxx pylint .
Traceback (most recent call last):
  File "/Users/myuser/projects/xxxx/.venv/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
             ^^^^^^^^^^^^
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint/__init__.py", line 34, in run_pylint
    PylintRun(argv or sys.argv[1:])
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint/lint/run.py", line 162, in __init__
    args = _config_initialization(
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint/config/config_initialization.py", line 61, in _config_initialization
    linter.load_plugin_modules(utils._splitstrip(config_data["load-plugins"]))
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint/lint/pylinter.py", line 380, in load_plugin_modules
    module = astroid.modutils.load_module_from_name(modname)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/astroid/modutils.py", line 194, in load_module_from_name
    module = importlib.import_module(dotted_name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/myuser/.pyenv/versions/3.11.2/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint_django/__init__.py", line 6, in <module>
    from pylint_django import plugin
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint_django/plugin.py", line 9, in <module>
    from pylint_django.checkers import register_checkers
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint_django/checkers/__init__.py", line 2, in <module>
    from pylint_django.checkers.auth_user import AuthUserChecker
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint_django/checkers/auth_user.py", line 7, in <module>
    class AuthUserChecker(checkers.BaseChecker):
  File "/Users/myuser/projects/xxxx/.venv/lib/python3.11/site-packages/pylint_django/checkers/auth_user.py", line 8, in AuthUserChecker
    __implements__ = (interfaces.IAstroidChecker,)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'pylint.interfaces' has no attribute 'IAstroidChecker'

NOTES: make sure you have the latest version of 3rd party packages
like rest_framework, factory, model_utils, etc. before reporting
issues!

[carlio]

Ah, thank you I had not realised pylint 3 was coming out soon. This is going to cause some headaches!

[Pierre-Sassoulas]

@carlio do you have an opinion on #400 ? I think it could be the first step.

[carlio]

I agree, I think that I've been clinging on to having as broad a range as possible to be as useful as possible to most people.

However several of the supported Django versions have been end of life even for security updates for more than a year.

I think the sensible thing to do is to release a 3.0 version of pylint-django which drops support for older Django versions. Certainly Django<3. Also removing the python 3.7 support.

I can put a little graph of what versions of (python, pylint, django) are supported and have tags, but it's probably better not to work around people who just don't update their own software, as this causes issues making it harder to keep pylint-django up to date for latest releases.

[Pierre-Sassoulas]

Let me know if I can help or do not hesitate to take over #400. I don't think there's going to be major incompatibilities with pylint 3.0.0 or anything truly painful to updates but it's hard to know for sure without running the CI first.

[matejsp]

I tried migrating to pylint 3.0.1 and I needed to make the following changes (based on https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html):

Options is now a tuple:

    name_checker = get_checker(linter, NameChecker)
    name_checker.options[0][1]['default'] = name_checker.options[0][1]['default'] + (
        "qs",
        "urlpatterns",
        "register",
        "app_name",
        "handler400",
        "handler403",
        "handler404",
        "handler500",
    )

Replace all @utils.check_messages to @utils.only_required_for_messages.

replace
self.config.django_settings_module
to
self.linter.config.django_settings_module

After that I managed to get it running.
I didn't prepare PR because I don't know if you want to preserve backwards compatibility or just support pylint 3.x

[GTorreil]

Hello,

Is there a known release date for this ?
Version solving is failing on my projects because of this.

Thanks !

[matejsp]

I have prepared the #407. But I am waiting for maintaner to merge this. @carlio any way to push this forward?

You can test the fix locally:

pip install git+https://github.com/matejsp/pylint-django.git@master

[carlio]

I am currently on holiday and travelling around so I will do my best to get to it but please be patient!

[GTorreil]

No worries, thank you ! :)