Fix versioning in unit tests #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pyexcel-webio==0.0.3 | ||
| pyexcel-xls==0.0.7 | ||
| pyexcel-xlsx==0.0.7 | ||
| -e git+https://github.com/T0ha/ezodf.git@2c69103e6c0715adb0e36562cb2e6325fd776112#egg=ezodf-master |
There was a problem hiding this comment.
The same comment as the one in pyexcel-io. Shall we use zip file instead of cloning it? Let's have zip and continue the merge
There was a problem hiding this comment.
That sounds fine by me! I don't like the idea of cloning it either - dependency management can be a nightmare for sure. I'll clean it up here soon.
|
I think I'll clean this up once pyexcel/pyexcel-io#5 gets merged in. It would be great if you could push an update to pypi on that one so we can say Thanks, @chfw! |
chfw
added a commit
that referenced
this pull request
Oct 25, 2015
Fix versioning in unit tests. Thanks and credit go to @fuhrysteve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests don't run out of the box because of some inconsistencies between what's hard-coded in .travis.yml. Frustrating trying to figure out which versions actually work together, but I figured it out.