PSM4 get_ functions: remove default values for year
#2471
Conversation
| # convert to string to accomodate integer years being passed in | ||
| year = str(year) | ||
|
|
There was a problem hiding this comment.
Why is this only removed for one of the functions? I see this is present for the other three functions as well.
I support the removal since this line doesn't seem to be necessary, but we should be consistent.
There was a problem hiding this comment.
The inconsistency is because this is the TMY function, where year is always a string ("tmy", "tgy-2020"). The other three deal with calendar years.
There was a problem hiding this comment.
On second thought, it's not needed in any of these functions anymore. It was a copy/paste from get_psm3, where the year input was inspected to determine the relevant API endpoint, and being a string facilitated that inspection. For PSM4 it serves no purpose since we have one function per endpoint here. All of them are now removed.
There was a problem hiding this comment.
Exactly! I just ran the tests locally with all the string conversion removed and tests are passing.
kandersolar
added
remote-data
[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.See #2378 (comment).
Note that these functions haven't been included in a release yet, so no problem to change default values like this.