-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Standardize pvgis_hourly to return (data,meta) #2462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamRJensen
commented
May 26, 2025
AdamRJensen
commented
May 26, 2025
kandersolar
reviewed
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change (move the inputs
dict to be within the returned metadata
dict instead of a separate variable) is okay with me.
A few minor suggestions below. Otherwise, my only feedback is that it would be nice if the descriptions of the metadata dict in Returns
were more useful.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.The
pvlib.iotools.get_pvgis_hourly
andread_pvigs_hourly
currently does not follow the iotools standard convention returning a tuple with (data,meta). Instead the functions currently output (data,inputs,meta), which is causing a lot of confusion for new users, particular this is a major pain point during intro tutorials. This PR introduces impelements a breaking change of by changing the output of the functions to follow the iotools standard convention.