Skip to content

changed unix file modes, so that the files are not executable #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2015

Conversation

bmu
Copy link
Contributor

@bmu bmu commented Mar 8, 2015

For some of the original files (I created a new clone to double check this), the unix file modes were set to 755, which means that they are executable (see #11).
I think, it should be save to merge this (however I am not 100% sure).
Maybe the best is to wait for travis and to test this on another linux machine.
Any others, that work on linux?

@bmu
Copy link
Contributor Author

bmu commented Mar 8, 2015

Ok, it fails, but the reason is a failure in test_tools. I'll create another pull request to fix this.

@bmu
Copy link
Contributor Author

bmu commented Mar 8, 2015

Something is going wrong here: test_tools.py seems to be outdated and is not tested on the other pull requests, but is tested on the one, that I submitted!

Any ideas?

@wholmgren
Copy link
Member

Good catches. I apparently missed updating test_tools.py on UARENForecasting/PVLIB_Python and I never noticed because nose didn't run the tests automatically due to the permissions issue.

Looks like everything in test_tools.py is for the old vars/expect pattern, so it will just be a stub when you remove all of that. This is fine with me for 0.1, but we should probably add some tests for 0.2.

@bmu
Copy link
Contributor Author

bmu commented Mar 9, 2015

Ok, so I think I should remove the file. Ok?

@wholmgren
Copy link
Member

Yes, we can add it back later if tools expands.
On Sun, Mar 8, 2015 at 10:34 PM bmu notifications@github.com wrote:

Ok, so I think I should remove the file. Ok?


Reply to this email directly or view it on GitHub
#18 (comment).

@bmu
Copy link
Contributor Author

bmu commented Mar 10, 2015

this should be ready to merge now (from my side).

wholmgren added a commit that referenced this pull request Mar 10, 2015
changed unix file modes, so that the files are not executable
@wholmgren wholmgren merged commit e0abcd7 into pvlib:master Mar 10, 2015
@wholmgren
Copy link
Member

Great, merged.

@bmu bmu deleted the unix_file_modes branch March 11, 2015 20:05
@bmu bmu added this to the 0.1 milestone Mar 12, 2015
@bmu bmu added the testing label Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants