Skip to content

Inconsistent parameter name in fit_sdm_cec_sam()? #958

Open
@Peque

Description

@Peque

The parameter beta_voc is named after v_oc.

The parameter alpha_sc is a bit inconsistent with this, since it should be alpha_isc (after i_sc).

In fact, the underlying SAM function also expects that name:

datadict = {'tech_model': '6parsolve', 'financial_model': None,
'celltype': celltype, 'Vmp': v_mp,
'Imp': i_mp, 'Voc': v_oc, 'Isc': i_sc, 'alpha_isc': alpha_sc,
'beta_voc': beta_voc, 'gamma_pmp': gamma_pmp,
'Nser': cells_in_series, 'Tref': temp_ref}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions