Skip to content

Adding tests that cover the ecma262 specs #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Adding tests that cover the ecma262 specs #80

wants to merge 3 commits into from

Conversation

Cmdv
Copy link

@Cmdv Cmdv commented Sep 22, 2020

Extending the tests to follow the JS Ecma262 specs for Date object.

  • turn the specs into something reasonably readable
  • work out what tests need to be added/moved to cover these specs
  • potentially have TODO tests for non existent functionality

@Cmdv
Copy link
Author

Cmdv commented Sep 22, 2020

I've converted the specs to something readable but need some pointers as to what in the current tests might relate to the specs, also what new tests I might need. As I'm not quite able to make the correlation between specs and current tests. 😄

@Cmdv
Copy link
Author

Cmdv commented Sep 23, 2020

would I be better off just setting up a whole new set of tests to make sure the library matches the specs?
I'm slightly reluctant as naming differ and don't want to take out tests that would be required, but I'm keen to keep things moving.

@garyb
Copy link
Member

garyb commented Sep 25, 2020

Yeah, I'd just make new tests for the spec stuff, and have them live together/structured similarly to the spec so they can be easily compared with the spec. I don't think it does any harm to potentially have two tests for the same thing, if it so happens that some of the existing tests were covering the same aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants