Skip to content

Drop getBoundingClientRect #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes:
- Move `getBoundingClientRect` to `purescript-web-dom` (#73 by @JordanMartinez)

New features:

Expand Down
14 changes: 0 additions & 14 deletions src/Web/HTML/HTMLElement.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,20 +185,6 @@ export function blur(elt) {

// - CSSOM ---------------------------------------------------------------------

export function getBoundingClientRect(el) {
return function () {
var rect = el.getBoundingClientRect();
return {
top: rect.top,
right: rect.right,
bottom: rect.bottom,
left: rect.left,
width: rect.width,
height: rect.height
};
};
}

export function _offsetParent(el) {
return function () {
return el.offsetParent;
Expand Down
13 changes: 0 additions & 13 deletions src/Web/HTML/HTMLElement.purs
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ module Web.HTML.HTMLElement
, click
, focus
, blur
, getBoundingClientRect
, DOMRect
, offsetParent
, offsetTop
, offsetLeft
Expand Down Expand Up @@ -133,17 +131,6 @@ foreign import click :: HTMLElement -> Effect Unit
foreign import focus :: HTMLElement -> Effect Unit
foreign import blur :: HTMLElement -> Effect Unit

type DOMRect =
{ top :: Number
, right :: Number
, bottom :: Number
, left :: Number
, width :: Number
, height :: Number
}

foreign import getBoundingClientRect :: HTMLElement -> Effect DOMRect

foreign import _offsetParent :: HTMLElement -> Effect (Nullable Element)

offsetParent :: HTMLElement -> Effect (Maybe Element)
Expand Down