Skip to content

Fix HiddenConstructors warnings #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Fix HiddenConstructors warnings #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ffadb
Fix `HiddenConstructors` warnings
kl0tl Jul 18, 2020
ad504b8
Remove unused explicit imports
kl0tl Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Web/HTML/Window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,23 +188,23 @@ exports.sessionStorage = function (window) {
};
};

exports._requestAnimationFrame = function(fn) {
exports.requestAnimationFrame = function(fn) {
return function(window) {
return function() {
return window.requestAnimationFrame(fn);
};
};
};

exports._cancelAnimationFrame = function(id) {
exports.cancelAnimationFrame = function(id) {
return function(window) {
return function() {
return window.cancelAnimationFrame(id);
};
};
};

exports._requestIdleCallback = function(opts) {
exports.requestIdleCallback = function(opts) {
return function(fn) {
return function(window) {
return function() {
Expand All @@ -214,7 +214,7 @@ exports._requestIdleCallback = function(opts) {
};
};

exports._cancelIdleCallback = function(id) {
exports.cancelIdleCallback = function(id) {
return function(window) {
return function() {
return window.cancelIdleCallback(id);
Expand Down
23 changes: 4 additions & 19 deletions src/Web/HTML/Window.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ module Web.HTML.Window
) where

import Data.Maybe (Maybe)
import Data.Newtype (class Newtype, unwrap)
import Data.Nullable (Nullable, toMaybe)
import Effect (Effect)
import Prelude (class Eq, class Ord, Unit, (<$>), (<<<), map)
Expand Down Expand Up @@ -121,37 +120,23 @@ foreign import sessionStorage :: Window -> Effect Storage

newtype RequestAnimationFrameId = RequestAnimationFrameId Int

derive instance newtypeRequestAnimationFrameId :: Newtype RequestAnimationFrameId _
derive instance eqRequestAnimationFrameId :: Eq RequestAnimationFrameId
derive instance ordRequestAnimationFrameId :: Ord RequestAnimationFrameId

foreign import _requestAnimationFrame :: Effect Unit -> Window -> Effect Int
foreign import requestAnimationFrame :: Effect Unit -> Window -> Effect RequestAnimationFrameId

requestAnimationFrame :: Effect Unit -> Window -> Effect RequestAnimationFrameId
requestAnimationFrame fn = map RequestAnimationFrameId <<< _requestAnimationFrame fn

foreign import _cancelAnimationFrame :: Int -> Window -> Effect Unit

cancelAnimationFrame :: RequestAnimationFrameId -> Window -> Effect Unit
cancelAnimationFrame idAF = _cancelAnimationFrame (unwrap idAF)
foreign import cancelAnimationFrame :: RequestAnimationFrameId -> Window -> Effect Unit

newtype RequestIdleCallbackId = RequestIdleCallbackId Int

derive instance newtypeRequestIdleCallbackId :: Newtype RequestIdleCallbackId _
derive instance eqRequestIdleCallbackId :: Eq RequestIdleCallbackId
derive instance ordRequestIdleCallbackId :: Ord RequestIdleCallbackId

foreign import _requestIdleCallback :: { timeout :: Int } -> Effect Unit -> Window -> Effect Int

-- | Set timeout to `0` to get the same behaviour as when it is `undefined` in
-- | [JavaScript](https://w3c.github.io/requestidlecallback/#h-the-requestidle-callback-method).
requestIdleCallback :: { timeout :: Int } -> Effect Unit -> Window -> Effect RequestIdleCallbackId
requestIdleCallback opts fn = map RequestIdleCallbackId <<< _requestIdleCallback opts fn

foreign import _cancelIdleCallback :: Int -> Window -> Effect Unit
foreign import requestIdleCallback :: { timeout :: Int } -> Effect Unit -> Window -> Effect RequestIdleCallbackId

cancelIdleCallback :: RequestIdleCallbackId -> Window -> Effect Unit
cancelIdleCallback idAF = _cancelIdleCallback (unwrap idAF)
foreign import cancelIdleCallback :: RequestIdleCallbackId -> Window -> Effect Unit

foreign import parent :: Window -> Effect Window

Expand Down