Update to v0.14.0-rc3 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl0tl
approved these changes
Dec 8, 2020
kl0tl
reviewed
Dec 8, 2020
spago.dhall
Outdated
Comment on lines
1
to
4
| {- | ||
| Welcome to a Spago project! | ||
| You can edit this file as you like. | ||
| -} |
There was a problem hiding this comment.
Shall we remove this comment?
.github/workflows/ci.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: CI | |||
|
|
|||
| on: push | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
Suggested change
| on: [push, pull_request] | |
| on: | |
| push: | |
| branches: [master] | |
| pull_request: | |
| branches: [master] |
spago.dhall
Outdated
Comment on lines
1
to
4
| {- | ||
| Welcome to a Spago project! | ||
| You can edit this file as you like. | ||
| -} |
There was a problem hiding this comment.
Suggested change
| {- | |
| Welcome to a Spago project! | |
| You can edit this file as you like. | |
| -} |
thomashoneyman
requested changes
Dec 9, 2020
spago.dhall
Outdated
| { name = "web-cssom" | ||
| , dependencies = [ "web-dom", "web-html", "psci-support" ] | ||
| , packages = ./packages.dhall | ||
| , sources = [ "src/**/*.purs", "test/**/*.purs" ] |
There was a problem hiding this comment.
Suggested change
| , sources = [ "src/**/*.purs", "test/**/*.purs" ] | |
| , sources = [ "src/**/*.purs" ] |
We can either trim the sources or add a dummy test.
|
@JordanMartinez looks like this library was missed when updating them all to 0.14.0-rc3 with Bower. |
|
@thomashoneyman Thanks. I've updated my PR to use bower rather than Spago |
|
CI builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlinking to purescript/purescript#3942