Drop typelevel-prelude dependency #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't actually using anything provided by typelevel-prelude; instead, we're only using its re-exports. Dropping the dependency and importing RLProxy and the Union class from where they are defined means that we have fewer dependencies to worry about, so version incompatibilities are less likely to occur. I'd suggest releasing this as a patch-level change; previously we have recommended releasing changes in which dependencies have been dropped as major-level, because it can break downstream libraries if they are relying on the presence of that dependency, but I have come to believe that this policy is worse since it results in far too many unnecessary major version bumps, and downstream libraries depending on a particular transitive dependency but not declaring that dependency are arguably broken anyway.
maddie927
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't actually using anything provided by typelevel-prelude;
instead, we're only using its re-exports. Dropping the dependency and
importing RLProxy and the Union class from where they are defined means
that we have fewer dependencies to worry about, so version
incompatibilities are less likely to occur.
I'd suggest releasing this as a patch-level change; previously we have
recommended releasing changes in which dependencies have been dropped as
major-level, because it can break downstream libraries if they are
relying on the presence of that dependency, but I have come to believe
that this policy is worse since it results in far too many unnecessary
major version bumps, and downstream libraries depending on a particular
transitive dependency but not declaring that dependency are arguably
broken anyway.