Skip to content

Fix displayName and name lifecycle functions #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2018
Merged

Fix displayName and name lifecycle functions #27

merged 1 commit into from
Mar 28, 2018

Conversation

maddie927
Copy link
Member

@maddie927 maddie927 commented Mar 28, 2018 •
edited
Loading

  • displayName was not being set correctly, so it wasn't doing anything
  • named lifecycle functions just makes debugging slightly better (call stack will display the lifecycle function name instead of another "anonymous"

@maddie927 maddie927 self-assigned this Mar 28, 2018
@paf31
Copy link
Contributor

paf31 commented Mar 28, 2018

👍

@maddie927 maddie927 merged commit ee7bb67 into master Mar 28, 2018
@maddie927 maddie927 deleted the michael/fix-displayname branch March 28, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maddie927 maddie927

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddie927 @paf31