This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Fix #8, add type constructor to SigProd #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change, so I'll merge it with #19, and release everything with compiler version 0.7.6. |
|
I guess this doesn't fail CI once the base branch is updated? Looks straightforward to me but I guess, yeah, wait for the next release :-) |
|
Yeah, I think the CI issue is because of the compiler changes needed. I'll release this alongside the compiler. |
This was referenced Nov 18, 2015
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gbaz Could you please review this? Obviously it needs compiler changes, which I'll add after this. I need this to implement an
aeson-compatible version offoreign-generic, handling things likeMaybeandEitherproperly.