Skip to content

Simpler types #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2015
Merged

Simpler types #52

merged 1 commit into from
Nov 19, 2015

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Nov 15, 2015

This is a breaking change.

  • Use rows instead of type constructors for read/write access types.
  • Don't track the state and props types in the effects. This has proven tricky in cases with nested components in libraries like Thermite, and is unnecessary since the context tracks those types anyway.

I'll leave this here for comment for a few days before merging.

@paf31 paf31 mentioned this pull request Nov 15, 2015
Closed
@paf31
Copy link
Contributor Author

paf31 commented Nov 19, 2015

If there's no feedback on this, I'll merge it today.

paf31 added a commit that referenced this pull request Nov 19, 2015
@paf31
Merge pull request #52 from purescript-contrib/simpler
12f9412 
Simpler types
@paf31 paf31 merged commit 12f9412 into master Nov 19, 2015
@paf31 paf31 deleted the simpler branch November 19, 2015 19:36
@paf31 paf31 mentioned this pull request Nov 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paf31