Add EncodeJson/DecodeJson instances for records #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Unless there are objections (@garyb) I'll merge this tomorrow. |
LiamGoodacre
approved these changes
Nov 8, 2018
|
I'm late on this, but no objections from me 😁 - I spoke to @elliotdavies a little while ago about this on Slack, thanks for working on it! |
|
Happy to help! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Addresses #37 by allowing users to call
encodeJsonanddecodeJsonfor record types. The relevant classes are implemented usingRowToList.How should this be manually tested?
We've been using this branch in production at Habito for a little while and we're happy it works! I've also added some basic quickcheck tests to test the encode/decode roundtrip but I can expand on these if you'd like.
Other Notes:
I changed
Decode.Classto export everything, same asEncode.Class. If you prefer I can changeEncode.Classto be more restrictive instead.