Skip to content

Fix warnings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fix warnings #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/Data/Argonaut/Decode/Class.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,18 @@ module Data.Argonaut.Decode.Class

import Prelude

import Data.Argonaut.Core (Json, JArray, JObject, isNull, foldJsonNull, foldJsonBoolean, foldJsonNumber, foldJsonString, toArray, toNumber, toObject, toString, toBoolean)
import Data.Array (zipWithA)
import Data.Argonaut.Core (Json, JArray, JObject, isNull, foldJsonNull, foldJsonBoolean, foldJsonNumber, foldJsonString, toArray, toObject, toString)
import Data.Bifunctor (lmap)
import Data.Either (Either(..))
import Data.Foldable (find)
import Data.Int (fromNumber)
import Data.List (List(..), (:), fromFoldable)
import Data.Map as M
import Data.Maybe (maybe, Maybe(..))
import Data.String (charAt, toChar)
import Data.String (charAt)
import Data.StrMap as SM
import Data.Traversable (traverse, for)
import Data.Traversable (traverse)
import Data.Tuple (Tuple(..))

import Type.Proxy (Proxy(..))

class DecodeJson a where
decodeJson :: Json -> Either String a

Expand Down
1 change: 0 additions & 1 deletion src/Data/Argonaut/Encode/Class.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import Prelude

import Data.Argonaut.Core (Json(), jsonNull, fromBoolean, fromNumber, fromString, fromArray, fromObject, jsonEmptyObject, jsonSingletonObject)
import Data.Either (Either(), either)
import Data.Foldable (foldr)
import Data.Int (toNumber)
import Data.List (List(..), (:), toUnfoldable)
import Data.Map as M
Expand Down
22 changes: 9 additions & 13 deletions test/Test/Main.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,21 @@ module Test.Main where

import Prelude

import Control.Monad.Eff.Console (log, logShow)
import Control.Monad.Eff.Console (log)

import Data.Argonaut.Core (JObject, Json, isObject, toObject, fromObject, fromArray, fromString, fromNumber, fromBoolean, jsonNull)
import Data.Argonaut.Core (JObject, Json, isObject, toObject)
import Data.Argonaut.Decode (decodeJson)
import Data.Argonaut.Encode (encodeJson, (:=), (~>))
import Data.Argonaut.Gen (genJson)
import Data.Array (zipWith, nubBy, length)
import Data.Either (Either(..))
import Data.Foldable (foldl)
import Data.Function (on)
import Data.List (fromFoldable)
import Data.Maybe (Maybe(..), maybe, isJust)
import Data.StrMap as SM
import Data.Tuple (Tuple(..), fst)
import Data.Tuple (Tuple(..))

import Test.StrongCheck (SC, quickCheck, quickCheck', (<?>))
import Test.StrongCheck.Arbitrary (class Arbitrary, arbitrary)
import Test.StrongCheck.Data.AlphaNumString (AlphaNumString(..))
import Test.StrongCheck.Gen (Gen, Size, showSample, sized, frequency, oneOf, vectorOf, suchThat, resize)
import Test.StrongCheck.Arbitrary (class Arbitrary)
import Test.StrongCheck.Gen (suchThat, resize)

main :: SC () Unit
main = do
Expand Down Expand Up @@ -80,17 +76,17 @@ combinatorsCheck = do
prop_assoc_append (Tuple (Tuple key (TestJson val)) (Obj obj)) =
let appended = (key := val) ~> obj
in case toObject appended >>= SM.lookup key of
Just val -> true
Just value -> true
_ -> false

prop_get_jobject_field :: Obj -> Boolean
prop_get_jobject_field (Obj obj) =
maybe false go $ toObject obj
where
go :: JObject -> Boolean
go obj =
let keys = SM.keys obj
in foldl (\ok key -> ok && isJust (SM.lookup key obj)) true keys
go object =
let keys = SM.keys object
in foldl (\ok key -> ok && isJust (SM.lookup key object)) true keys

eitherCheck :: SC () Unit
eitherCheck = do
Expand Down