Skip to content

Update dependencies #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@
},
"license": "MIT",
"dependencies": {
"purescript-argonaut-core": "^1.0.0",
"purescript-generics": "^1.0.0",
"purescript-integers": "^1.0.0"
"purescript-argonaut-core": "^2.0.0",
"purescript-generics": "^3.0.0",
"purescript-integers": "^2.0.0"
},
"devDependencies": {
"purescript-strongcheck": "^1.1.1",
"purescript-strongcheck-generics": "garyb/purescript-strongcheck-generics#0.9.1-updates"
"purescript-strongcheck": "^2.0.0"
}
}
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"test": "pulp test"
},
"devDependencies": {
"pulp": "^9.0.0",
"pulp": "^9.0.1",
"purescript-psa": "^0.3.9",
"purescript": "^0.9.1",
"rimraf": "^2.5.0"
"purescript": "^0.10.1",
"rimraf": "^2.5.4"
}
}
12 changes: 4 additions & 8 deletions src/Data/Argonaut/Decode/Class.purs
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,10 @@ module Data.Argonaut.Decode.Class

import Prelude

import Control.Alt ((<|>))
import Control.Bind ((=<<))
import Data.Bifunctor (lmap)
import Data.Argonaut.Core (Json, JArray, JObject, isNull, foldJsonNull, foldJsonBoolean, foldJsonNumber, foldJsonString, toArray, toNumber, toObject, toString, toBoolean)
import Data.Array (zipWithA)
import Data.Either (either, Either(..))
import Data.Bifunctor (lmap)
import Data.Either (Either(..))
import Data.Foldable (find)
import Data.Generic (class Generic, GenericSpine(..), GenericSignature(..), fromSpine, toSignature)
import Data.Int (fromNumber)
Expand All @@ -23,6 +21,7 @@ import Data.String (charAt, toChar)
import Data.StrMap as SM
import Data.Traversable (traverse, for)
import Data.Tuple (Tuple(..))

import Type.Proxy (Proxy(..))

class DecodeJson a where
Expand Down Expand Up @@ -132,13 +131,10 @@ instance decodeList :: DecodeJson a => DecodeJson (List a) where
<<< (traverse decodeJson <=< map (map fromFoldable) decodeJArray)

instance decodeMap :: (Ord a, DecodeJson a, DecodeJson b) => DecodeJson (M.Map a b) where
decodeJson = map M.fromList <<< decodeJson
decodeJson = map (M.fromFoldable :: List (Tuple a b) -> M.Map a b) <<< decodeJson

decodeJArray :: Json -> Either String JArray
decodeJArray = maybe (Left "Value is not an Array") Right <<< toArray

decodeJOject :: Json -> Either String JObject
decodeJOject = maybe (Left "Value is not an Object") Right <<< toObject

decodeMaybe :: forall a. DecodeJson a => Json -> Maybe a
decodeMaybe = either (const Nothing) pure <<< decodeJson
2 changes: 1 addition & 1 deletion src/Data/Argonaut/Decode/Combinators.purs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Prelude
import Data.Argonaut.Core (JObject)
import Data.Argonaut.Decode.Class (class DecodeJson, decodeJson)
import Data.Either (Either(..))
import Data.Maybe (Maybe(Just, Nothing), maybe)
import Data.Maybe (Maybe(..), maybe)
import Data.StrMap as SM

getField :: forall a. DecodeJson a => JObject -> String -> Either String a
Expand Down
2 changes: 1 addition & 1 deletion src/Data/Argonaut/Encode/Class.purs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ instance encodeJsonEither :: (EncodeJson a, EncodeJson b) => EncodeJson (Either
where
obj :: forall c. EncodeJson c => String -> c -> Json
obj tag x =
fromObject $ SM.fromList $
fromObject $ SM.fromFoldable $
Tuple "tag" (fromString tag) : Tuple "value" (encodeJson x) : Nil

instance encodeJsonUnit :: EncodeJson Unit where
Expand Down
22 changes: 3 additions & 19 deletions test/Test/Main.purs
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ import Prelude
import Control.Monad.Eff.Console (log, logShow)

import Data.Argonaut.Core (JObject, Json, toObject, fromObject, fromArray, fromString, fromNumber, fromBoolean, jsonNull)
import Data.Argonaut.Decode (decodeJson, gDecodeJson')
import Data.Argonaut.Encode (encodeJson, gEncodeJson, gEncodeJson', (~>), (:=))
import Data.Argonaut.Decode (decodeJson)
import Data.Argonaut.Encode (encodeJson, gEncodeJson, (:=), (~>))
import Data.Array (zipWith, nubBy, length)
import Data.Either (Either(..))
import Data.Foldable (foldl)
import Data.Function (on)
import Data.Generic (class Generic, isValidSpine)
import Data.Generic (class Generic)
import Data.List (fromFoldable)
import Data.Maybe (Maybe(..), maybe, isJust)
import Data.StrMap as SM
Expand All @@ -21,7 +21,6 @@ import Test.StrongCheck (SC, quickCheck, quickCheck', (<?>))
import Test.StrongCheck.Arbitrary (class Arbitrary, arbitrary)
import Test.StrongCheck.Data.AlphaNumString (AlphaNumString(..))
import Test.StrongCheck.Gen (Gen, Size, showSample, sized, frequency, oneOf, vectorOf)
import Test.StrongCheck.Generic (GenericValue, runGenericValue)

main :: SC () Unit
main = do
Expand Down Expand Up @@ -155,10 +154,6 @@ derive instance genericUser :: Generic User

genericsCheck :: SC () Unit
genericsCheck = do
log "Check that gDecodeJson' and gEncodeJson' form an isomorphism"
quickCheck prop_iso_generic
log "Check that gDecodeJson' returns a valid spine"
quickCheck prop_decoded_spine_valid
log "Print samples of values encoded with gEncodeJson"
logShow $ gEncodeJson 5
logShow $ gEncodeJson [1, 2, 3, 5]
Expand Down Expand Up @@ -189,17 +184,6 @@ genericsCheck = do
}
]
}
where

prop_iso_generic :: GenericValue -> Boolean
prop_iso_generic genericValue =
Right val.spine == gDecodeJson' val.signature (gEncodeJson' val.spine)
where val = runGenericValue genericValue

prop_decoded_spine_valid :: GenericValue -> Boolean
prop_decoded_spine_valid genericValue =
Right true == (isValidSpine val.signature <$> gDecodeJson' val.signature (gEncodeJson' val.spine))
where val = runGenericValue genericValue

eitherCheck :: SC () Unit
eitherCheck = do
Expand Down