(FM-7780) - Acceptance Test Audit #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying out a test audit it appears that most functions are tested at both the acceptance and unit test level. With these being functions all we need to care about is the inputs and output. All this can be tested in unit tests. Acceptance tests have been removed where applicable and we have ensured that all use cases are being covered in the unit tests.
Note: Any acceptance tests that have been removed, we have ensured they are being tested at unit level therefore code coverage is not reduced.
This effort has been carried out by both myself and @eimlav.
These results are for a full run of our Jenkins pipeline including smoke tests and agent only testing for 2018.1 and 2019.0.