(MODULES-6894) - Puppet 5.5.0 function deprecation #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcmaw
force-pushed
the
puppet_550_corrections
branch
11 times, most recently
from
968480c to
fbe25ce
Compare
pmcmaw
changed the title
pmcmaw
force-pushed
the
puppet_550_corrections
branch
from
7823ec5 to
e9a31e0
Compare
jbondpdx
suggested changes
Mar 22, 2018
pmcmaw
force-pushed
the
puppet_550_corrections
branch
3 times, most recently
from
93b2b95 to
3e19e09
Compare
|
Thanks @jbondpdx I have made these changes. 👍 |
jbondpdx
approved these changes
Mar 22, 2018
pmcmaw
force-pushed
the
puppet_550_corrections
branch
from
981439f to
a376238
Compare
pmcmaw
force-pushed
the
puppet_550_corrections
branch
from
8da322f to
331118f
Compare
hunner
reviewed
Mar 26, 2018
lib/puppet/functions/length.rb
Outdated
| @@ -11,4 +11,5 @@ def length(value) | |||
| end | |||
| result | |||
| end | |||
| Puppet.deprecation_warning('The length function is deprecated. This function is now shipped with Puppet in versions 5.5.0 and later. For more information please see Puppet 5.5.0 Release Notes.') | |||
There was a problem hiding this comment.
These functions should only be deprecated for users using puppet >=5.5.0, not for users running puppet <5.5.0. So it shouldn't print the deprecation warnings on puppet <5.5.0.
Users running >=5.5.0 will not be able to call these functions without specially trying, so I don't think printing a deprecating warning for >=5.5.0 will actually be helpful.
So we probably don't need to print them at all, and thus don't need to test for them.
README.md
Outdated
| @@ -1163,6 +1163,8 @@ Converts the case of a string or of all strings in an array to lowercase. | |||
|
|
|||
| #### `empty` | |||
|
|
|||
| **Deprecated. Puppet 5.5.0 has introduced a built in `empty` function, which will take precedence over the stdlib function. See [Puppet 5.5.0 Release Notes](https://puppet.com/docs/puppet/5.5/release_notes.html#new-features).** | |||
There was a problem hiding this comment.
The functions should only be deprecated for users of puppet >=5.5.0, but not for users of puppet <5.5.0. We can remove them from stdlib entirely when we drop compatibility for puppet <6.0.0 from stdlib in 2050 or whatever :P.
Sometimes the word "deprecated" was all caps, sometimes just capitalized. Sometimes followed by a period, sometimes a colon. Sometimes just the word was bold, sometimes the whole line. Updated to be capitalized, colonized, and only bolding the word.
The dig() deprecation message is clear and applies to these functions as well. Also linked to the documentation instead of the release notes.
hunner
force-pushed
the
puppet_550_corrections
branch
from
6394b3f to
67c1c2b
Compare
eputnam
approved these changes
Mar 26, 2018
pmcmaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://puppet.com/docs/puppet/5.5/release_notes.html#new-features
The following functions have been implemented in puppet 5.5.0. As these functions in puppet take precedence over stdlib functions. We are deprecating these functions and addressing additional failures introduced with the release.
flattenemptyjoinkeysvalueslength