(MODULES-6771) - Updates to README. #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jbondpdx, I have requested your review as these are the changes that we were chatting about last night. Hopefully they are up to scratch. The last few entries I have added the URL to the page for examples, hoping this is sufficient. 👍 |
jbondpdx
suggested changes
Mar 9, 2018
README.md
Outdated
| Match the same things as the `Stdlib::IP::Address` alias, except it will not | ||
| match an address that includes an address prefix (e.g., it will match | ||
| `192.168.0.6` but not `192.168.0.6/24`). | ||
| Match the same things as the `Stdlib::IP::Address` alias, except it will not match an address that includes an address prefix (e.g., it will match '192.168.0.6' but not '192.168.0.6/24'). |
There was a problem hiding this comment.
e.g. is hard for translation; use 'for example' instead please
There was a problem hiding this comment.
I see some other ones, so I think you could just do a search and replace.
jbondpdx
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes includes:
These changes are being PR'd directly against the release branch as these are required before the module can be released.