(MODULES-6332) - PDK convert #881
Conversation
pmcmaw
force-pushed
the
pdk_convert
branch
2 times, most recently
from
f4ad17c to
a5febf2
Compare
| @@ -0,0 +1,4 @@ | |||
| Style/HashSyntax: | |||
| EnforcedStyle: hash_rockets | |||
There was a problem hiding this comment.
This is required to avoid making the module backwards compatible.
| Style/HashSyntax: | ||
| EnforcedStyle: hash_rockets | ||
| RSpec/NamedSubject: | ||
| Enabled: false |
There was a problem hiding this comment.
Unsure how ok this is?
It used to be disabled and there are a serious amount of violations of this cop. It would result in some files being completely rewritten.
There was a problem hiding this comment.
I would say this is fine for now. Plus it won't get lost if it's in the todo, so seems perfect solution for the meantime.
pmcmaw
changed the title
|
|
||
| include RspecPuppetFacts | ||
|
|
||
| # rubocop:disable Style/HashSyntax |
There was a problem hiding this comment.
The disable/enable of Style/HashSyntax is a work around that will need to be resolved, the change will be overwritten on the next pdk update.
There was a problem hiding this comment.
I have raised an internal bug for tracking this and it has been added onto the backlog.
We will need to come up with some type of solution going forward.
pmcmaw
changed the title
Firstly running pdk convert to make the module pdk compliant.
Second commit is disabling Style/HashSyntax around code within the spec/spec_helper.rb.
Reason: stdlib is a special case where we enforce the usage of hash_rockets, this avoids the module becoming backwards incompatible. The spec_helper.rb is written by a pdk template so even if I implemented hash rockets on the next
pdk updaterun it will be overwritten. This is something to consider before the nextpdk updateis ran and on the next run these changes will be reverted.