Skip to content

Ability to skip undef values in to_json_pretty() #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2017
Merged

Ability to skip undef values in to_json_pretty() #855

merged 2 commits into from
Nov 29, 2017

Conversation

pegasd
Copy link
Contributor

@pegasd pegasd commented Nov 28, 2017

Note that I also added a trailing newline at the end of to_json_pretty() output. Seems like a desirable change since usually we output to a file.

@pmcmaw pmcmaw merged commit eefd770 into puppetlabs:master Nov 29, 2017
@pmcmaw
Copy link
Contributor

pmcmaw commented Nov 29, 2017

@pegasd thank you for your contribution, it is much appreciated 👍

@pegasd pegasd deleted the to_json_pretty_update branch November 29, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pegasd @pmcmaw @jordanbreen28