Skip to content

Add Stdlib::Mode type #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,30 @@ Unacceptable input example:
C:/whatever
```

#### `Stdlib::Filemode`

Matches valid four digit modes in octal format.

Acceptable input examples:

```shell
0644
```

```shell
1777
```

Unacceptable input examples:

```shell
644
```

```shell
0999
```

#### `Stdlib::Windowspath`

Matches paths on Windows operating systems.
Expand Down
48 changes: 48 additions & 0 deletions spec/aliases/filemode_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
require 'spec_helper'

if Puppet::Util::Package.versioncmp(Puppet.version, '4.5.0') >= 0
describe 'test::filemode', type: :class do
describe 'valid modes' do
%w{
0644
1644
2644
4644
0123
0777
}.each do |value|
describe value.inspect do
let(:params) {{ value: value }}
it { is_expected.to compile }
end
end
end

describe 'invalid modes' do
context 'garbage inputs' do
[
nil,
[ nil ],
[ nil, nil ],
{ 'foo' => 'bar' },
{ },
'',
"ネット",
'644',
'7777',
'1',
'22',
'333',
'55555',
'0x123',
'0649',
].each do |value|
describe value.inspect do
let(:params) {{ value: value }}
it { is_expected.to compile.and_raise_error(/parameter 'value' expects a match for Stdlib::Filemode/) }
end
end
end
end
end
end
6 changes: 6 additions & 0 deletions spec/fixtures/test/manifests/filemode.pp
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Class to test the Stdlib::Filemode type alias
class test::filemode (
Stdlib::Filemode $value,
) {
notice("Success")
}
1 change: 1 addition & 0 deletions types/filemode.pp
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
type Stdlib::Filemode = Pattern[/^[0124]{1}[0-7]{3}$/]