MODULES-4008: clarify deprecation language #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbondpdx I like the language changes. And, now that I've read the note you added to the functions, I do realize that your original suggestion of pointing to validate_legacy as a way to address these deprecations is a very good one. Apologies. Finally, all the is_* functions (except is_a()) from https://github.com/puppetlabs/puppetlabs-stdlib/tree/master/lib/puppet/functions are also deprecated. |
|
@DavidS Awesome, thank you for looking at this. I've updated the PR if you'd give it another look and merge, if appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to clarify (I hope) deprecation language and note which functions are deprecated.