Skip to content

Improve fqdn_rotate/fqdn_rand_string acceptance tests #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2015
Merged

Improve fqdn_rotate/fqdn_rand_string acceptance tests #466

merged 2 commits into from
Jun 3, 2015

Conversation

elyscape
Copy link
Contributor

@elyscape elyscape commented Jun 1, 2015

This adds acceptance tests validating custom seed functionality in fqdn_rotate() and custom character set functionality in fqdn_rand_string().

This depends on #462.

@puppet-community-ci
Copy link

The result of the test was: PASS
Details at http://ci.puppet.community/buildlogspuppetlabs+puppetlabs-stdlib+466+1433203662+PASS

I am a beta ci bot. I am probably lying to you.
You can contact nibalizer for more details.

@elyscape elyscape force-pushed the fix/improve_fqdn_acceptance_tests branch from 7c2f0b2 to 52c2b1e Compare June 2, 2015 00:09
@puppet-community-ci
Copy link

The result of the test was: PASS
Details at http://ci.puppet.community/buildlogspuppetlabs+puppetlabs-stdlib+466+1433204950+PASS

I am a beta ci bot. I am probably lying to you.
You can contact nibalizer for more details.

@DavidS
Copy link
Contributor

DavidS commented Jun 2, 2015

After merging #462 , this seems to need a rebase to remove the already merged commits from here. Also, looking back at this, I'd rather had the fqdn_rotate tests from here in #462, and the fqdn_rand_string in a separate PR, marked as such.

@puppet-community-ci
Copy link

The result of the test was: PASS
Details at http://ci.puppet.community/buildlogspuppetlabs+puppetlabs-stdlib+466+1433244347+PASS

I am a beta ci bot. I am probably lying to you.
You can contact nibalizer for more details.

@puppet-community-ci
Copy link

The result of the test was: PASS
Details at http://ci.puppet.community/buildlogspuppetlabs+puppetlabs-stdlib+466+1433247217+PASS

I am a beta ci bot. I am probably lying to you.
You can contact nibalizer for more details.

@elyscape elyscape force-pushed the fix/improve_fqdn_acceptance_tests branch from 52c2b1e to 98c2f28 Compare June 2, 2015 19:02
@elyscape
Copy link
Contributor Author

elyscape commented Jun 2, 2015

@DavidS: Ah, sorry. Should I split this into two PRs or leave it as one?

@puppet-community-ci
Copy link

The result of the test was: PASS
Details at http://ci.puppet.community/buildlogspuppetlabs+puppetlabs-stdlib+466+1433272953+PASS

I am a beta ci bot. I am probably lying to you.
You can contact nibalizer for more details.

@DavidS
Copy link
Contributor

DavidS commented Jun 3, 2015

Nah, it's fine. I'll merge that now and let the jenkins sort out the rest.

DavidS added a commit that referenced this pull request Jun 3, 2015
@DavidS
Merge pull request #466 from elyscape/fix/improve_fqdn_acceptance_tests
09b427b 
Improve fqdn_rotate/fqdn_rand_string acceptance tests
@DavidS DavidS merged commit 09b427b into puppetlabs:master Jun 3, 2015
@elyscape elyscape deleted the fix/improve_fqdn_acceptance_tests branch June 3, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elyscape @puppet-community-ci @DavidS @jordanbreen28