(#1) Adds a standard spool directory to stdlib #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a standard place to store file fragments for use by other modules. Uses a fact so that vardir is accesible on the agent side. Also cleans up documentation to match the style guide.
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
jeffmccune
pushed a commit
to jeffmccune/puppetlabs-stdlib
that referenced
this pull request
Aug 4, 2011
| # Turns puppet's agent side vardir configuration setting into a fact so we can use it | ||
| # in our manifests. | ||
|
|
||
| Facter.add(:vardir) do |
There was a problem hiding this comment.
I'd rather not merge this with a fact named $vardir. It could be confusing from a manifest if you're referring to the client vardir or the agent vardir.
Maybe rename this as $client_vardir ?
|
Closing this pull request for the time being. Cody, please open a new one or grab me if you'd like to talk about the facts and spool directory. |
jeffmccune
pushed a commit
that referenced
this pull request
Aug 8, 2011
Closes pull request #12 Reviewed-by: Jeff McCune Verified all spec tests pass using rspec **/*_spec.rb * issue/master/8797_puppetlabs-functions_merge: (164 commits) * Moved kwalify to puppetlabs-kwalify project * Re-arranged tests in line with puppetlabs-stdlib Prep for stdlib merge * Renamed load_yaml & load_json to parseyaml & parsejson * Renamed is_valid_* functions and remove the 'valid_' Fix some ruby 1.9.2 issues. (#3) Provide documentation for remaining functions. (#3) Apply missing documentation to more functions. Remove rand. Some improvements to values_at tests. (#1) provide some more detailed tests for a number of functions. Removed date stub since this functinality is available in strftime anyway. (#2) fix is_string finally so it also makes sure numbers return false. (#2) unstub is_valid_domain_name Added doc strings for first five functions Removed join_with_prefix. (#2) unstub is_valid_mac_address. Allow sort for strings. Count functionality overlaps with size - so removing it. Removed crontab functions instead of unstubbing them. Removed load_variables. load_yaml is sufficient to solve this problem on its own. Remove is_valid_netmask instead of unstubbing. Doesn't seem like a sensible function on its own. (#2) unstub is_numeric function. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a standard place to store file fragments for use by other
modules. Also cleans up documentation to match the style guide.