Fix fqdn_rotate determinism #1396
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed in e2d8b18 and ever since fqqdn_rotate has changed result on every succesive run.
DLDur
requested review from
alexjfisher,
b4ldr,
bastelfreak,
ekohl,
smortex,
seanmil and
a team
as code owners
|
|
let me see if I can fit this in. |
|
Fixed in #1341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in e2d8b18 and ever since fqdn_rotate has changed result on every successive run.
Summary
Seed fqdn_rotate with the appropriate fact to restore consistency in its output.
Additional Context
Issue was identifed after upgrading to stdlib 9.0.0 - files with contents depending on result of fqdn_rotate were refreshing every run.
Related Issues (if any)
May need to review original reason for the original change in e2d8b18
Checklist
puppet apply)