Add a function to update / regenerate deprecated shims #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
requested review from
a team,
alexjfisher,
b4ldr,
bastelfreak and
ekohl
as code owners
has_interface_with is a functionBreaking changes to this file MAY impact these 8 modules (near match):This module is declared in 318 of 580 indexed public
|
smortex
force-pushed
the
manage-unnamespaced-shims
branch
2 times, most recently
from
2f4fd92 to
c1089c1
Compare
smortex
force-pushed
the
manage-unnamespaced-shims
branch
from
c1089c1 to
d4048fb
Compare
alexjfisher
reviewed
May 23, 2023
Rakefile
Outdated
| repeated_param 'Any', :args | ||
| end | ||
| def deprecation_gen(*args) | ||
| call_function('deprecation', '#{function_name}', 'This method is deprecated, please use stdlib::#{function_name} instead.') |
There was a problem hiding this comment.
Entirely my bad as I tend to use method and function interchangeably. In puppet land though, functions are only ever really referred to as functions.
Suggested change
| call_function('deprecation', '#{function_name}', 'This method is deprecated, please use stdlib::#{function_name} instead.') | |
| call_function('deprecation', '#{function_name}', 'This function is deprecated, please use stdlib::#{function_name} instead.') |
There was a problem hiding this comment.
Good catch! Fixed!
smortex
force-pushed
the
manage-unnamespaced-shims
branch
from
d4048fb to
7c1dbc0
Compare
In order to move existing unamespaced functions to the stdlib namespace (puppetlabs#1346) without breaking backwards compatibility, we need some compatibility shims. They will all look-like the same, so add a rake task to regenerate them if we need to update them.
smortex
force-pushed
the
manage-unnamespaced-shims
branch
from
7c1dbc0 to
14b4150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to move existing unamespaced functions to the stdlib namespace
(#1346) without breaking backwards compatibility, we need some
compatibility shims. They will all look-like the same, so add a rake
task to regenerate them if we need to update them.
This will help with #1346.