Skip to content

Remove deprecated downcase function #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

Remove deprecated downcase function #1318

merged 1 commit into from
Apr 26, 2023

Conversation

MartyEwings
Copy link
Contributor

Note: Deprecated from Puppet 6.0.0, this function has been replaced with a
built-in downcase function.

@puppet-community-rangefinder
Copy link

downcase is a function

Breaking changes to this file MAY impact these 258 modules (near match):

This module is declared in 318 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

LukasAud
LukasAud approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smortex
smortex approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There also is an upcase function we can remove for the same reason.

@alexjfisher
Copy link
Collaborator

Do you think this (and lots of the similar PRs) actually needs be be marked as breaking? If the function has been built-in since Puppet 6 and we dropped 5 a long time ago?? Unlike say, has_key that is deprecated because there's a puppet native way of achieving the same.

@MartyEwings
Copy link
Contributor Author

Im not sure, i can go back and get them changed, this was more so the resulting version change would be a Major version, but i guess dropping puppet 6 will also do that...

@david22swan david22swan merged commit 048e837 into puppetlabs:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@LukasAud LukasAud LukasAud approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@b4ldr b4ldr Awaiting requested review from b4ldr b4ldr is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartyEwings @alexjfisher @smortex @LukasAud @david22swan