Add Stdlib::Ensure::Package type

[arjenz]

Like the ones for file, service.
Valid values taken from https://puppet.com/docs/puppet/7/types/package.html#package-attribute-ensure

[GSPatton]

this looks good. Could you add a unit test for this change? Thanks

[jordanbreen28]

Hi @arjenz,
Did you get the chance to implement @GSPatton's requested changes above?
Thanks

[arjenz]

@jordanbreen28 Not yet, I wanted to copy the tests for the similar types in there, but there weren't any yet, I will try and get to that this week and push accordingly, thanks!

[jordanbreen28]

@arjenz Thanks! Appreciate your work on this one.

[david22swan]

@arjenz Hey, just checking in on whether you've made any progress on this?

[ekohl]

I can see the benefits of explicit for documentation purposes. You could write a small test (https://rspec-puppet.com/documentation/type_aliases/) to make sure it's valid, but 👍 to this.

[GSPatton]

as @ekohl suggested, could you add a couple of test cases to ensure this new type works consistently in the future? After which we would be happy to merge. Thanks

[arjenz]

Having some issues on M1 laptop getting the tests to run (and unfortunately the other types don't have similar tests yet), I'll try and create a test.

[ekohl]

unfortunately the other types don't have similar tests yet

There are a bunch of them: https://github.com/puppetlabs/puppetlabs-stdlib/tree/main/spec/type_aliases

[arjenz]

I can see the benefits of explicit for documentation purposes. You could write a small test (https://rspec-puppet.com/documentation/type_aliases/) to make sure it's valid, but 👍 to this.

@ekohl
Done!

[arjenz]

I don't think any of the failing checks are related to my change

[ekohl]

Thanks!

[LukasAud]

LGTM

[LukasAud]

Thanks for your contribution!