Skip to content

(GH-1262) Use 'require_relative' to load stdlib due to lookup errors #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2022
Merged

(GH-1262) Use 'require_relative' to load stdlib due to lookup errors #1264

merged 2 commits into from
Aug 17, 2022

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner August 15, 2022 13:14
@david22swan david22swan mentioned this pull request Aug 15, 2022
Closed
ekohl
ekohl previously approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common problem. I wonder if we can somehow find a CI check for such a thing. No idea what the right way is and which tool to use, but users should be able to find these kind of problems early.

@ekohl ekohl linked an issue Aug 15, 2022 that may be closed by this pull request
to_toml function is not working #1262
Closed
@LukasAud LukasAud merged commit af84845 into puppetlabs:main Aug 17, 2022
@david22swan david22swan deleted the GH-1262/main branch August 17, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@LukasAud LukasAud LukasAud approved these changes

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_toml function is not working
4 participants
@david22swan @ekohl @bastelfreak @LukasAud