pdksync - (Maint) PDK Update #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Apr 20, 2022
| - name: Run Static & Syntax Tests | ||
| if: ${{ github.repository_owner == 'puppetlabs' }} | ||
| run: | | ||
| buildevents cmd $TRACE_ID $STEP_ID 'static_syntax_checks' -- bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop |
There was a problem hiding this comment.
I don't really understand why this is so complex. It can be this easy:
Suggested change
| buildevents cmd $TRACE_ID $STEP_ID 'static_syntax_checks' -- bundle exec rake syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop | |
| buildevents cmd $TRACE_ID $STEP_ID 'static_syntax_checks' -- bundle exec rake validate lint check rubocop |
I also submitted a PR for this in puppetlabs/pdk-templates#441 but it looks like this is lost somehow?
LukasAud
reviewed
May 5, 2022
| @@ -115,5 +115,5 @@ | |||
| "description": "Standard Library for Puppet Modules", | |||
| "pdk-version": "2.3.0", | |||
There was a problem hiding this comment.
isn't pdk-version supposed to be 2.4.0?
There was a problem hiding this comment.
ah, the version updated in between the original commit and when I added the fixes and exclusions. Since this one required no exclusions a second pdksync wasn't run
There was a problem hiding this comment.
This is fine to merge.
It doesn't really mean much
LukasAud
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Maint) PDK Update
pdk version:
2.3.0