Skip to content

Release prep v8.0.0 #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Release prep v8.0.0 #1203

merged 1 commit into from
Aug 24, 2021

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 24, 2021

Automated release-prep through pdk-templates from commit 375f8d2.
Please verify before merging:

@github-actions github-actions bot requested a review from a team as a code owner August 24, 2021 13:24
@david22swan david22swan merged commit ef80b24 into main Aug 24, 2021
@david22swan david22swan deleted the release-prep branch August 24, 2021 14:44
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdlib major versions are very painful for module authors. I don't think we should release them so often. This is a really trivial change and there's no effect on users so 👎 on doing a major version for this.

@alexjfisher
Copy link
Collaborator

stdlib major versions are very painful for module authors. I don't think we should release them so often. This is a really trivial change and there's no effect on users so 👎 on doing a major version for this.

Looks to be too late :(

@alexjfisher
Copy link
Collaborator

This is really annoying. Would it have been possible to at least release new versions of other puppetlabs modules to allow stdlib 8.0.0 before merging and releasing this? eg. concat?

This is blocking lots of other workflows now. eg. https://github.com/voxpupuli/puppet-gitlab_ci_runner/pull/114/checks?check_run_id=3420567928#step:6:334

@saz
Copy link

saz commented Aug 26, 2021

I'm seriously considering, to get rid of the upper version limit on stdlib. stdlib is used in soooo many modules, it takes days to weeks to get everything up-to-date and I don't want to add useless work with my modules.
Less major releases will help here... And marking breaking changes as such. Looking at the changelog, the last breaking change was with version 5...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants