(Bug) - Remove default switch of UpdateEnabled=false when Action=Install #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
changed the title
jordanbreen28
force-pushed
the
maint-fix_install_flags
branch
6 times, most recently
from
232af9d to
19a73f7
Compare
Prior to this commit, since v3.3.0 of this module, the Install switch /UpdateEnabled always defaulted to FALSE when the instance /ACTION=Install. This took away the ability for users to be able to configure this install switch themselves, and is an obvious bug. Now, this no longer automatically prepends the flag to install switches when action=install, and allows users to configure this through install_switches property once again.
jordanbreen28
force-pushed
the
maint-fix_install_flags
branch
from
19a73f7 to
19d435b
Compare
Ramesh7
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, since v3.3.0 of this module, the Install switch
/UpdateEnabledalways defaulted toFALSEwhen the instance/ACTION=Install. This took away the ability for users to be able to configure this install switch themselves, and is an obvious bug.Additional Context
Introduced in #420
Related Issues (if any)
Fixes #462
Checklist
puppet apply)