Skip to content

(CONT-800) - Add Puppet 8/Drop Puppet 6 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Apr 26, 2023
Merged

(CONT-800) - Add Puppet 8/Drop Puppet 6 #430

merged 51 commits into from
Apr 26, 2023

Conversation

jordanbreen28
Copy link
Contributor

No description provided.

david22swan and others added 15 commits April 24, 2023 09:43
@david22swan
(CONT-800) PDK Update
fa51f4c
@david22swan
(CONT-800) Add Support for Puppet 8 / Remove Support for Puppet 6
dcc0c7e
@david22swan
(CONT-800) Re-pin puppet_agent
25fc51e
@david22swan
(CONT-800) Update Rubocop Versions
1d20f92 
New Versions:
rubocop = 1.48.1
rubocop-performance = 1.16.0
rubocop-rspec = 2.19.0
@david22swan
(CONT-800) Rubocop Manual Fix 1 - Lint/RedundantCopEnableDirective
10f931f
@david22swan
(CONT-800) Disable .rubocop.yml rule to prevent interaction with .rub…
1f073be 
…ocop-todo.yml
@david22swan
(CONT-800) Set Rubocop to 2.6 Ruby
3a5f9fc
@david22swan
(CONT-800) Unit Test Fix
6b91257
(CONT-800) - Correct Layout/ArgumentAlignment
ff68473
(CONT-800) - Correct Layout/ClosingHeredocIndentation
bb2e9ff
(CONT-800) - Correct Layout/EmptyLineAfterGuardClause
756ba8b
(CONT-800) - Correct Layout/HashAlignment
da19ef5
(CONT-800) - Correct Layout/HeredocIndentation
0f3dd8c
(CONT-800) - Correct Layout/SpaceAroundMethodCallOperator
8a1b360
(CONT-800) - Correct Lint/ConstantDefinitionInBlock
7ef51bd
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner April 25, 2023 09:55
@jordanbreen28 jordanbreen28 self-assigned this Apr 25, 2023
@jordanbreen28 jordanbreen28 mentioned this pull request Apr 25, 2023
Closed
@puppet-community-rangefinder
Copy link

sqlserver_is_domain_or_local_user is a function

that may have no external impact to Forge modules.

sqlserver_validate_instance_name is a function

that may have no external impact to Forge modules.

sqlserver_validate_range is a function

that may have no external impact to Forge modules.

sqlserver_validate_size is a function

that may have no external impact to Forge modules.

sqlserver_features is a type

that may have no external impact to Forge modules.

sqlserver_instance is a type

that may have no external impact to Forge modules.

sqlserver_tsql is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 3 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

jordanbreen28 added 26 commits April 25, 2023 11:05
(CONT-800) - Correct RSpec/EmptyLineAfterExampleGroup
a48c983
(CONT-800) - Correct RSpec/EmptyLineAfterHook
9652e03
(CONT-800) - Correct RSpec/ExcessiveDocstringSpacing
ae4498e
(CONT-800) - Correct RSpec/ImplicitSubject
e135abf
(CONT-800) - Install mount_iso v4
8b04d79
(CONT-800) - Correct RSpec/ReceiveNever
69a5218
(CONT-800) - Correct Style/FetchEnvVar
d749b52
(CONT-800) - Correct Style/HashConversion
26b6107
(CONT-800) - Correct Style/IfUnlessModifier
b9d65fc
(CONT-800) - Fix specs
a29e2d3
(CONT-800) - Correct Style/IfWithBooleanLiteralBranches
0ad8aff
(CONT-800) - Correct Style/MixinUsage
ecb388d
(CONT-800) - Correct Style/NumericPredicate
80e987e
(CONT-800) - Correct Style/RedundantRegexpEscape
edb4c76
(CONT-800) - Correct Style/RedundantSelfAssignmentBranch
79583b9
(CONT-800) - Correct Style/RedundantStringEscape
e8c3ba1
(CONT-800) - Correct Style/RegexpLiteral
097ee2f
(CONT-800) - Correct Style/RescueStandardError
46ab3d9
(CONT-800) - Correct Style/SoleNestedConditional
c3a8710
(CONT-800) - Correct Style/StringConcatenation
79cc92b
(CONT-800) - Correct Style/TernaryParentheses
2d5a6c3
(CONT-800) - Correct Style/TrailingCommaInHashLiteral
563c464
(CONT-800) - fix mount_iso install
26db924
(CONT-800) - Fix Acceptance
084c649
(CONT-800) - Remove instances of deprecated is_array
ab5b684
(CONT-800) - Add Env variables to ci/nightly
e1fc3af
GSPatton
GSPatton approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@GSPatton GSPatton merged commit d7b64c2 into main Apr 26, 2023
@GSPatton GSPatton deleted the CONT-800-add_puppet8_support branch April 26, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton approved these changes

Assignees

@jordanbreen28 jordanbreen28

Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanbreen28 @GSPatton @david22swan