Various cleanups #967
Merged
Various cleanups #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Mar 13, 2018
| @@ -59,12 +59,13 @@ | |||
| end | |||
|
|
|||
| it { is_expected.to contain_postgresql__server__role('test') } | |||
| it 'has create role for "test" user with password as ****' do | |||
| it 'has create role for "test" user with password as ****' do # rubocop:disable RSpec/ExampleLength | |||
There was a problem hiding this comment.
The regression test suite failure seems related to this change
Since PUP-8008 is fixed in 4.10.9 and 5.3.3, this workaround is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing #950 I needed verious cleanups. Because that PR is hard to finish, it's best to get these (safe) cleanups in so there's less changes in mid air. This reduces the change of merge conflicts.
See individual commits for the exact changes.