Skip to content

Add EL9 support #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add EL9 support #1591

merged 1 commit into from
Jul 31, 2024

Conversation

bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@SimonHoenscheid
Copy link
Collaborator

SimonHoenscheid commented Apr 15, 2024

EL9 manages the default postgres in dnf modules, the postgres repo does not.

Recommended way is to disable the postgres dnf modules and install from the postgres repo.

the postgres repo requires a version which is defined via postgresql::globals::version, this is also the default version which is passed to the dnf module via the globals_version variable, which would need a value of 'disabled' here, to act correcty, the globals class requires a patch to make this possible.

My suggestion is to add an optional_parameter like dnf_module_version, unless set real_dnf_module_version defaults to $version/global_version.

https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/globals.pp#L289

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EL9 manages the default postgres in dnf modules, the postgres repo does not.

For plain EL9 this isn't true:

# dnf install postgresql
...
# dnf module list --enabled -q

You can install PostgreSQL 15 or 16 via modules, but the default (13) is not modular.

The reason the test fails is that it sets manage_dnf_module to true and version to '13'. That isn't a combination that exists.

The easiest fix is to pick a version that exists in both EL 8 & 9 as modular versions, which means picking 15 or 16.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ekohl ekohl merged commit 93bf0b5 into puppetlabs:main Jul 31, 2024
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants