Skip to content

Add Fedora 39 support #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Add Fedora 39 support #1580

merged 1 commit into from
Mar 26, 2024

Conversation

lweller
Copy link
Contributor

@lweller lweller commented Mar 18, 2024

Summary

Added default PostreSQL version for Fedora 39

Additional Context

Add any additional context about the problem here.

  • [n/a] Root cause and the steps to reproduce. (If applicable)
  • [n/a] Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • [n/a] 🟢 Spec tests.
  • [n/a] 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

Copy link
Contributor

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that https://packages.fedoraproject.org/pkgs/postgresql/postgresql/ shows that Fedora 39 has postgresql 15.6-1.fc39.

@bastelfreak bastelfreak changed the title Added Fedora 39 support Add Fedora 39 support Mar 18, 2024
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the tests fail on

LoadError: cannot load such file -- puppetlabs_spec_helper/rake_tasks

@ekohl
Copy link
Collaborator

ekohl commented Mar 26, 2024

Could you rebase? There was a PDK update so perhaps a rebase helps.

I also checked Fedora 40, but there the package naming changed: it's now postgresqlXX instead, so you can install multiple versions in parallel. This may require more changes so let's separate those.

@ekohl ekohl mentioned this pull request Mar 26, 2024
3 tasks
@ekohl
Copy link
Collaborator

ekohl commented Mar 26, 2024

I've taken the liberty to rebase the commit so hopefully the tests are green and we can get a release out.

@bastelfreak bastelfreak merged commit 188d1e5 into puppetlabs:main Mar 26, 2024
@lweller
Copy link
Contributor Author

lweller commented Mar 28, 2024

Thx @ALL for merging the PR.

@lweller lweller deleted the fedora39 branch March 30, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants