Skip to content

Revert "puppetlabs/stdlib: Require 9.x" #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Revert "puppetlabs/stdlib: Require 9.x" #1480

merged 1 commit into from
Aug 30, 2023

Conversation

bastelfreak
Copy link
Collaborator

@bastelfreak bastelfreak commented Aug 29, 2023

Reverts #1449

To ensure we can do a minor release, we will try to revert this, do a minor release, apply it again.

This reverts e142268

@bastelfreak
Copy link
Collaborator Author

I'm not sure if it's a good idea to have a check for latest modules that's enforced.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that sometimes you just aren't ready for latest yet. Makes me wonder if there's a way to suppress it.

Technically you can call it compatible with the latest version, you just get deprecation warnings. On Puppet 7 that's no problem and on Puppet 8 you can work around it now (I think).

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 content wise, but perhaps label it as Bring back compatibility with stdlib < 9.

@bastelfreak bastelfreak changed the title Revert "puppetlabs/stdlib: Require 9.x" Bring back compatibility with stdlib < 9 Aug 29, 2023
@bastelfreak
Copy link
Collaborator Author

now I'm not sure yet how we properly reflect this in the changelog, but the tests should pass.

ekohl
ekohl previously approved these changes Aug 29, 2023
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't be too worried. Especially if we quickly release a new major after which brings proper compatibility.

deric
deric previously approved these changes Aug 29, 2023
@smortex
Copy link
Collaborator

smortex commented Aug 29, 2023

now I'm not sure yet how we properly reflect this in the changelog, but the tests should pass.

I would make sure both do not appear in the changelog (abuse the maintenance tag?)

@bastelfreak bastelfreak dismissed stale reviews from deric and ekohl via aa7595d August 30, 2023 11:01
@bastelfreak bastelfreak changed the title Bring back compatibility with stdlib < 9 Revert "puppetlabs/stdlib: Require 9.x" Aug 30, 2023
@bastelfreak
Copy link
Collaborator Author

this now reverts #1449 completely. That allows us to skip both PRs for the changelog.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss the reference that git revert e142268e9aa9f802a861d42bed2f7039bb8d6295 would generate, but otherwise 👍 for the approach.

@bastelfreak
Copy link
Collaborator Author

I added the sha to the PR message

@ekohl ekohl merged commit e9e0ee9 into main Aug 30, 2023
@ekohl ekohl deleted the revert-1449-stdlib9 branch August 30, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants