-
Notifications
You must be signed in to change notification settings - Fork 614
Revert "puppetlabs/stdlib: Require 9.x" #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not sure if it's a good idea to have a check for latest modules that's enforced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that sometimes you just aren't ready for latest yet. Makes me wonder if there's a way to suppress it.
Technically you can call it compatible with the latest version, you just get deprecation warnings. On Puppet 7 that's no problem and on Puppet 8 you can work around it now (I think).
0464bf9
to
8f6c13c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 content wise, but perhaps label it as Bring back compatibility with stdlib < 9
.
now I'm not sure yet how we properly reflect this in the changelog, but the tests should pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't be too worried. Especially if we quickly release a new major after which brings proper compatibility.
I would make sure both do not appear in the changelog (abuse the |
8f6c13c
to
aa7595d
Compare
this now reverts #1449 completely. That allows us to skip both PRs for the changelog. |
aa7595d
to
f0fa975
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss the reference that git revert e142268e9aa9f802a861d42bed2f7039bb8d6295
would generate, but otherwise 👍 for the approach.
I added the sha to the PR message |
This reverts e142268
f0fa975
to
2bec262
Compare
Reverts #1449
To ensure we can do a minor release, we will try to revert this, do a minor release, apply it again.
This reverts e142268