Skip to content

uniform port parameter and $port_override value assignment #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

uniform port parameter and $port_override value assignment #1469

wants to merge 2 commits into from

Conversation

SimonHoenscheid
Copy link
Collaborator

fixes #1468

ekohl
ekohl requested changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hard time processing this change, but the current implementation is a regression IMHO and needs some work. I'd also consider this backwards incompatible.

@SimonHoenscheid
Copy link
Collaborator Author

@ekohl thanks for the feedback, I made some changes.

@SimonHoenscheid SimonHoenscheid force-pushed the database_and_permission_defines_port_behaviour branch from 20265da to 86efa5c Compare August 25, 2023 18:53
@SimonHoenscheid
Copy link
Collaborator Author

drop in favor of #1487

@ekohl ekohl mentioned this pull request Aug 31, 2023
Merged
5 tasks
@SimonHoenscheid SimonHoenscheid deleted the database_and_permission_defines_port_behaviour branch September 8, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher alexjfisher is a code owner

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@deric deric Awaiting requested review from deric deric is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identical $port_override behaviour
3 participants
@SimonHoenscheid @ekohl @ia-content